[lr/goodbye-libnm-glib-❤] all: goodbye libnm-glib #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkundrak
force-pushed
the
lr/goodbye-libnm-glib-❤
branch
from
b569dc0
to
05a39ae
Compare
|
let's hold this off until after (Because it's helpful to compare |
thom311
added
the
needs-work
This removes libnm-glib, libnm-glib-vpn, and libnm-util for good. The it has been replaced with libnm since NetworkManager 1.0, disabled by default since 1.12 and no up-to-date distributions ship it for years now. Removing the libraries allows us to: * Remove the horrible hacks that were in place to deal with accidental use of both the new and old library in a single process. * Relief the translators of maintenance burden of similar yet different strings. * Get rid of known bad code without chances of ever getting fixed (libnm-glib/nm-object.c and libnm-glib/nm-object-cache.c) * Generally lower the footprint of the releases and our workspace If there are some really really legacy users; they can just build libnm-glib and friends from the NetworkManager-1.16 distribution. The D-Bus API is stable and old libnm-glib will keep working forever.
lkundrak
force-pushed
the
lr/goodbye-libnm-glib-❤
branch
from
05a39ae
to
2c53d1b
Compare
ollieparanoid
pushed a commit
to ollieparanoid/aports
that referenced
this pull request
Apr 3, 2019
Currently, it can't be installed (missing so:libnm-glib.so.4). I've tried to bump the pkgrel only, but it won't build anymore because the legacy libnm has been removed in the NetworkManager release we are using (NetworkManager/NetworkManager#308). Add --without-libnm-gtk to fix it.
ollieparanoid
pushed a commit
to ollieparanoid/aports
that referenced
this pull request
Apr 3, 2019
Currently, it can't be installed (missing so:libnm-glib.so.4). I've tried to bump the pkgrel only, but it won't build anymore because the legacy libnm has been removed in the NetworkManager release we're using (NetworkManager/NetworkManager#308). Add --without-libnm-gtk to fix it.
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Apr 3, 2019
Currently, it can't be installed (missing so:libnm-glib.so.4). I've tried to bump the pkgrel only, but it won't build anymore because the legacy libnm has been removed in the NetworkManager release we're using (NetworkManager/NetworkManager#308). Add --without-libnm-gtk to fix it.
liske
pushed a commit
to liske/aports
that referenced
this pull request
Apr 7, 2019
Currently, it can't be installed (missing so:libnm-glib.so.4). I've tried to bump the pkgrel only, but it won't build anymore because the legacy libnm has been removed in the NetworkManager release we're using (NetworkManager/NetworkManager#308). Add --without-libnm-gtk to fix it.
tcely
pushed a commit
to tcely/aports
that referenced
this pull request
Apr 8, 2019
Currently, it can't be installed (missing so:libnm-glib.so.4). I've tried to bump the pkgrel only, but it won't build anymore because the legacy libnm has been removed in the NetworkManager release we're using (NetworkManager/NetworkManager#308). Add --without-libnm-gtk to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes libnm-glib, libnm-glib-vpn, and libnm-util for good.
The it has been replaced with libnm since NetworkManager 1.0, disabled
by default since 1.12 and no up-to-date distributions ship it for years
now.
Removing the libraries allows us to:
of both the new and old library in a single process.
strings.
(libnm-glib/nm-object.c and libnm-glib/nm-object-cache.c)
If there are some really really legacy users; they can just build
libnm-glib and friends from the NetworkManager-1.16 distribution. The
D-Bus API is stable and old libnm-glib will keep working forever.