-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add marqo as a sink #35
Conversation
Reviewing PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for adding exception off the bat.
Only comment is on the filtering for search. Might be able to bring it in,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change for delete vector capability.
@ddematheu @kevinco26 I have added |
Author: Aakash Thatte
Description: This PR intends to add marqo as a sink.
Note: I have individually tested each added function (like
store
,search
etc) onNeumVector
objects.I have also opened an issue for this(just to make sure that contributors know its being worked on), Looking forward for a review.