Add LanceDB sink #40
Merged
Add LanceDB sink #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddematheu
requested changes
Dec 18, 2023
Comment on lines
51
to
52
| api_key: str = Field(default=None, description="API key for LanceDB cloud") | ||
| region: str = Field(default=None, description="Region for use of LanceDB cloud") |
There was a problem hiding this comment.
Are these optional fields? If so, type should be Optional[str]
There was a problem hiding this comment.
Yes they are optional, made the changes.
ddematheu
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author: Aakash Thatte
Description: This PR intends to add lancedb, an embedded vector db as a sink to Neum AI.
I have tested all functionalities, and they are working. Looking forward for a review.