Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR intends to add a unified filtering interface to neum ai, which can be mapped to filters of respective sinks. To test this, I have made changes to
MarqoSink
and tested them. Addresses this issue.Approach: To start with, I have assumed that the user provides the filter as a string like
"field1 <= value1, field2 != value2"
which is then mapped to a class calledFilterCondition
. This is subject to change as per discussions and review.Example usage:
Note: Benefit of this unified filter over dictionary is that we can now add range based queries.