Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This Pull Request fixes #377 #389

Closed
wants to merge 6 commits into from

Conversation

jschuecker
Copy link
Contributor

This should not be merged until nest/nest-simulator#158 is merged.

@apdavison
Copy link
Member

Our policy is that the PyNN master branch should always work with the most recent released version of NEST, so once NEST 2.10 is released we can merge this into master. In the meantime, I could create a nest-dev branch for people wishing to use PyNN master with NEST master, and merge your fix into that. What do you think?

@jschuecker
Copy link
Contributor Author

@apdavison, that sounds good to me!

@mschmidt87
Copy link
Contributor

I just added 2 commits that fix the unittests of NEST in pyNN if run against NEST 2.10.
However, the Travis CI system fails. As far as I can see, there are two problems:

  1. Travis tries to download the release version of NEST with a false URL.
  2. Travis tries to download NEST 2.6.0, but the newest release version is NEST 2.10.

The URL in travis should thus be changed to
https://github.com/nest/nest-simulator/releases/download/v2.10.0/nest-2.10.0.tar.gz

@apdavison
Copy link
Member

Hi @jschuecker, please can you re-open this pull request against the nest-dev branch? (I know that NEST 2.10 has already been released, but I'd like to test the workflow).

@jschuecker
Copy link
Contributor Author

@apdavison, I have re-opened the pull request against the nest-dev branch.

@apdavison
Copy link
Member

Closed in favour of #392

@apdavison apdavison closed this Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants