Fixes 491: updates recording to handle individual cells as PopulationView #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -477,8 +477,11 @@ def write_data(self, io, variables='all', gather=True, clear=False, annotations= | |||
| file as metadata. | |||
| """ | |||
| logger.debug("Population %s is writing %s to %s [gather=%s, clear=%s]" % (self.label, variables, io, gather, clear)) | |||
| # ignoring the method parameter 'annotations', and using class attribute 'self.annotations' | |||
| # seems ok as this method parameter does not seem to be used within pynn currently. | |||
| # TODO: decide whether this method parameter needs to be retained. | |||
There was a problem hiding this comment.
@apdavison : Does this method require to accept 'annotations' as an input parameter? From a quick grep in the pynn directory, it appeared as if none of the function calls pass this parameter to the method.
|
@apdavison : Is this a Travis config issue? Errors such as: showing up. |
| if isinstance(source, (IDMixin)): | ||
| source = source.as_view() | ||
| else: | ||
| # not sure when this would be used; retaining earlier code |
There was a problem hiding this comment.
@apdavison : do you see any scenario where this would be used? should we remove it?
|
PR Closed; Merged with PR #494. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix issue #491.
The recording is now updated to handle individual cells as PopulationView.
PopulationView class is accordingly updated to include an 'annotations' attribute.
@apdavison : Do let me know if this resolves the problem. Preliminary checks seem to suggest so. Also, take a look at the comments on lines 480-482 of pyNN/common/populations.py
p.s. Any thoughts on how to devise test cases for this. Is it ok to check saved output files in test cases? If so, will add these tests along with upcoming related fixes.