Fixes #497: tweaks phase for NEST ACSource #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecording not available in master
|
and But the problem arises if the user specified a different |
|
Fix (and test) updated to handle the above. Looks good for now. |
pgleeson
added a commit
to pgleeson/PyNN
that referenced
this pull request
Aug 4, 2017
* master: (66 commits) Update Travis Fixes NeuralEnsemble#497: tweaks phase for NEST ACSource (NeuralEnsemble#502) Implement `Grid3D.generate_positions()` for `fill_order="random"` (fix for NeuralEnsemble#504) Fixes issue NeuralEnsemble#499: updates sim.end() for Brian Updates NeuralEnsemble#459: Updates docstring of find_units() Updates NeuralEnsemble#459: Adds docstring to find_units() Fixes 459: Extends find_units() for neuron parameters Removes recording sub-test for mock - needs reimplementation with pyNN.mock Fix a test that fails with NumPy 1.13 Temporarily install quantities from github, due to python-quantities/python-quantities#129 Still trying to fix NEST build with Python 2.7 on Travis Updates NeuralEnsemble#490, NeuralEnsemble#491; minor changes It seems a recent NumPy change made it an error to treat a single-element array as a scalar for the purposes of indexing. Numpy became much more strict about certain arguments being int not float Travis updated to Python 2.7.13 (need to find a way to avoid hard-coding this in the NEST install script) Updates NeuralEnsemble#490 (also fixes NeuralEnsemble#449): handles recording without file Fixes issue NeuralEnsemble#490: moves write_on_end to populations.py Fixes 491: updates recording to handle individual cells as PopulationView Updates fix for issue NeuralEnsemble#487 - handles boundary condition Fixes issue NeuralEnsemble#487: Updates _update_iclamp() for NEURON ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #497 (see for details)
Tweaks the value of
phasesupplied to NEST ACSource so as to remain consistent with other simulators. The test case for this fix requires the recording of current profiles. As the final current recording implementation is currently unavailable in the 'master' branch, the test has been excluded for the time being. Tested locally to ensure it works.