Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #482 - Handles timestamps of StepCurrentSource for NEST #513

Merged
merged 4 commits into from
Sep 5, 2017

Conversation

appukuttan-shailesh
Copy link
Contributor

@appukuttan-shailesh appukuttan-shailesh commented Aug 30, 2017

Continuing on the discussion under issue #482 :
The sequence of steps for NEST is now as follows:
(consider dt = min_delay = 0.1 ms)

  1. User inputs a time series, e.g.
    times = [0.0, 0.1, 0.2, 0.3, 0.4, 0.5]
  2. _delay_correction() will subtract min_delay (set to 0.0, if result is negative), so
    times = [0.0, 0.0, 0.1, 0.2, 0.3, 0.4]
  3. We now scan the time series to find the last element matching dt. This corresponds to the first timestamp that can be used by NEST for current injection. All prior timestamps (and corresponding amplitudes) are removed. So we have
    times = [0.1, 0.2, 0.3, 0.4]

A thorough test case for the StepCurrentSource across all simulators will be developed for issue #512 , and thus the same is avoided here.

The fix has been tested for the issue reported for the Izhikevich model under OpenSourceBrain (see here) and found to resolve the same.

@coveralls
Copy link

coveralls commented Aug 30, 2017

Coverage Status

Coverage decreased (-0.02%) to 54.162% when pulling 0fb6fe1 on appukuttan-shailesh:fixes_482 into ad00b7a on NeuralEnsemble:master.

@coveralls
Copy link

coveralls commented Aug 31, 2017

Coverage Status

Coverage increased (+0.02%) to 54.209% when pulling 75d3a6b on appukuttan-shailesh:fixes_482 into ad00b7a on NeuralEnsemble:master.

@apdavison apdavison merged commit 44d1500 into NeuralEnsemble:master Sep 5, 2017
@appukuttan-shailesh appukuttan-shailesh deleted the fixes_482 branch May 6, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants