Fixes #482 - Handles timestamps of StepCurrentSource for NEST #513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on the discussion under issue #482 :
The sequence of steps for NEST is now as follows:
(consider
dt = min_delay = 0.1 ms
)times = [0.0, 0.1, 0.2, 0.3, 0.4, 0.5]
_delay_correction()
will subtractmin_delay
(set to 0.0, if result is negative), sotimes = [0.0, 0.0, 0.1, 0.2, 0.3, 0.4]
dt
. This corresponds to the first timestamp that can be used by NEST for current injection. All prior timestamps (and corresponding amplitudes) are removed. So we havetimes = [0.1, 0.2, 0.3, 0.4]
A thorough test case for the StepCurrentSource across all simulators will be developed for issue #512 , and thus the same is avoided here.
The fix has been tested for the issue reported for the Izhikevich model under OpenSourceBrain (see here) and found to resolve the same.