Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 538 #548

Merged
merged 3 commits into from
Dec 5, 2017
Merged

Issue 538 #548

merged 3 commits into from
Dec 5, 2017

Conversation

appukuttan-shailesh
Copy link
Contributor

Fixes parts 1 and 2 of issue #538.

@apdavison : The original code has this bit:

                try:
                    D[name] = eval(value)
                except Exception:
                    D[name] = value.strip()

Is there any reason to retain the "strip()" part. I have removed this currently. eval() seemed to work fine with extra whitespaces at the ends.

@coveralls
Copy link

Coverage Status

Coverage decreased (-11.8%) to 42.535% when pulling 9add5f5 on appukuttan-shailesh:issue_538 into 215e74b on NeuralEnsemble:master.

@coveralls
Copy link

coveralls commented Dec 5, 2017

Coverage Status

Coverage increased (+0.01%) to 54.317% when pulling 640c21a on appukuttan-shailesh:issue_538 into 215e74b on NeuralEnsemble:master.

@apdavison apdavison merged commit ca83843 into NeuralEnsemble:master Dec 5, 2017
@appukuttan-shailesh appukuttan-shailesh deleted the issue_538 branch May 6, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants