Add ArrayParameter class, and use it to simplify GIF_cond_exp model
#551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that the broken tests with the last commit are due to the release of Brian 1.4.4. It seems that the Brian system tests were being skipped with Brian 1.4.3. Also note that some of the test failures are labelled "neuron" or "nest", but it appears they are actually brian failures, not sure why the mislabelling is happening. |
|
I faced a similar situation with the mislabeling of test failures here: It shows: "FAIL: issue512(neuron)" The error is shown on a line which wouldn't run for NEURON (only for NEST) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ArrayParameterwill also be used in future for other models with array-valued (or tuple-value) parameters.