-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to setup.py and other misc tweaks #574
Updates to setup.py and other misc tweaks #574
Conversation
sanjayankur31
commented
Jun 19, 2018
•
edited
Loading
edited
- Prefer setuptools if available
- update setup.py to include run time dependencies, optional dependencies, and dependencies needed by tests.
Failed test:
It seems the nest extensions could not be installed:
|
It appears that |
Yes. I just read that too. I reckon something like build_ext must be used. I'll update the PR in a bit. Thanks. |
When required, these libraries are installed in the virtualenv via pip. For example, install_brian.sh installs scipy for python2.7, or the tests pull it in for python>=3.4 (scipy supports 2.7 and 3.4+ only)
So there appear to be multiple ways of implementing this. One can override build or install or a plethora of other commands. I've done two versions:
I'm not entirely sure yet why the test fails for one and not for the other. As far as the tests are concerned, they should be doing identical things. I cannot find a way to get pip to build the extensions in the second method. The first method should still work. |
I've merged the bits that build all the extensions by default, keeping it in line with the previous way the build worked. |
Many thanks for this! |