Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for irregular sampling intervals when recording #754

Merged
merged 4 commits into from
Jun 16, 2022

Conversation

apdavison
Copy link
Member

for NEURON with cvode or for BrainScaleS-2

…vode in NEURON).

The implementation so far assumes all neurons in the same population have the same sample times.
…recorded sample times.

This has been manually tested, but only applies to BrainScaleS-2 at the moment, unless we add a setup option to use local timesteps in cvode in NEURON.
@coveralls
Copy link

coveralls commented May 31, 2022

Coverage Status

Coverage decreased (-0.02%) to 69.847% when pulling b34e53a on apdavison:irregular-sampling into 5bf3823 on NeuralEnsemble:master.

@AvidusMauch
Copy link

saving IrregularlySampledSignal types in segment.analogsignals seams to break write/read_block of NeoMatlabIO probably because it only expects AnalogSingal in that array.
IrregularlySampledSignals are meant to be stored in segment.irregularlysampledsignals probably?
Or do IrregularlySampledSignals just need to be supported in general by NeoMatlabIO?

@apdavison
Copy link
Member Author

@AvidusMauch thanks for spotting that. Indeed, IrregularlySampledSignals are meant to be stored in segment.irregularlysampledsignals.

(this is likely to change before we release Neo 1.0, but for now it is the case)

@apdavison
Copy link
Member Author

apdavison commented Jun 2, 2022

also, NeoMatlabIO doesn't support IrregularlySampledSignal - I've opened a ticket for this: NeuralEnsemble/python-neo#1126

@apdavison apdavison merged commit 2bd75ae into NeuralEnsemble:master Jun 16, 2022
@apdavison apdavison deleted the irregular-sampling branch September 8, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants