Implementation of covariance #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved bug in non-working unit test where wrong variable was used. Added squeeze statement to resulting CC/cov matrix to mimic numpy behavior. Small fixes Merged main bodies of corrcoef and covariance in a single function, since code overlaps almost completely.
| @@ -11,15 +11,80 @@ | |||
| import numpy as np | |||
|
|
|||
|
|
|||
| def covariance(binned_sts, binary=False): | |||
There was a problem hiding this comment.
what is an sts? I think binned_spiketrains would be much clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the
covariance()function. It is closely related to thecorrcoef()function, and therefore overlapping code between correlation coefficient and covariance was moved to a new private function.