Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with units in BinnedSpikeTrain #425

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

PaulinaDabrowska
Copy link
Contributor

BinnedSpikeTrain does not properly rescale t_start and t_stop to the units of input spiketrains (spiketrains[0].units) in case they differ. A small correction in two lines of code solved the issue for me.

@coveralls
Copy link
Collaborator

coveralls commented Jun 11, 2021

Coverage Status

Coverage decreased (-0.2%) to 88.678% when pulling 4f7de65 on INM-6:fix/binnedspiketrain_units into 6479381 on NeuralEnsemble:master.

@mdenker
Copy link
Member

mdenker commented Jun 14, 2021

Hi Paulina, thanks for the fix!

@mdenker mdenker self-requested a review June 14, 2021 06:47
@mdenker mdenker added the bugfix Fix for an indentified bug. label Jun 14, 2021
@mdenker mdenker added this to the v0.11.0 milestone Jun 14, 2021
@mdenker mdenker merged commit 784fb8d into NeuralEnsemble:master Jan 10, 2022
@Moritz-Alexander-Kern Moritz-Alexander-Kern mentioned this pull request Mar 9, 2022
1 task
@Moritz-Alexander-Kern Moritz-Alexander-Kern deleted the fix/binnedspiketrain_units branch October 28, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix for an indentified bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants