Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove version cap for scipy #473

Merged
merged 1 commit into from Apr 14, 2022
Merged

remove version cap for scipy #473

merged 1 commit into from Apr 14, 2022

Conversation

Moritz-Alexander-Kern
Copy link
Member

This PR removes the version cap for scipy (<1.7.0).

This cap was introduced here: 1d29550 .

@Moritz-Alexander-Kern Moritz-Alexander-Kern mentioned this pull request Apr 12, 2022
Closed
@Moritz-Alexander-Kern Moritz-Alexander-Kern linked an issue Apr 12, 2022 that may be closed by this pull request
[Feature] Remove scipy version cap #470
Closed
mdenker
mdenker approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@mdenker mdenker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workaround for limiting scipy is indeed no longer required.

@Moritz-Alexander-Kern Moritz-Alexander-Kern merged commit 23d0680 into NeuralEnsemble:master Apr 14, 2022
@mdenker mdenker added this to the v0.11.1 milestone Apr 14, 2022
@Moritz-Alexander-Kern Moritz-Alexander-Kern deleted the enh/remove_scipy_version_cap branch April 26, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdenker mdenker mdenker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.1
Development

Successfully merging this pull request may close these issues.

[Feature] Remove scipy version cap
2 participants
@Moritz-Alexander-Kern @mdenker