Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] deprecation warnings numpy 1.25.0 #568

Merged
merged 8 commits into from Jun 26, 2023
Merged

[Fix] deprecation warnings numpy 1.25.0 #568

merged 8 commits into from Jun 26, 2023

Conversation

Moritz-Alexander-Kern
Copy link
Member

@Moritz-Alexander-Kern Moritz-Alexander-Kern commented May 30, 2023 •
edited

Deprecation

  1. The default behavior of numpy.linalg.lstsq will be changed, to fix this, set a parameter for rcond
  • set to rcond = None in granger
  1. Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation.
  • fixed in gpfa, icsd, phase analysis
  1. changed import from numpy.testing.utils to numpy.testing
  2. Comment out example in doc string of icsd unittest, pytest is trying to run this as a docstest
  3. replaced np.matrix with ndarray in KCSD

@coveralls
Copy link
Collaborator

coveralls commented May 30, 2023 •
edited

Coverage Status

Coverage: 86.755% (+0.3%) from 86.418% when pulling 19de003 on INM-6:fix/numpy_1_25_0 into c7b5814 on NeuralEnsemble:master.

@Moritz-Alexander-Kern
Copy link
Member Author

Thanks @rjurkus for your help approval on point 1, rcond = None .

Moritz-Alexander-Kern
Moritz-Alexander-Kern commented Jun 26, 2023
View reviewed changes
Copy link
Member Author

@Moritz-Alexander-Kern Moritz-Alexander-Kern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build wheels

@Moritz-Alexander-Kern Moritz-Alexander-Kern merged commit 2651da9 into NeuralEnsemble:master Jun 26, 2023
17 checks passed
@Moritz-Alexander-Kern Moritz-Alexander-Kern deleted the fix/numpy_1_25_0 branch June 26, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdenker mdenker mdenker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moritz-Alexander-Kern @coveralls @mdenker