Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] cell assembly detection #576

Merged

Conversation

Moritz-Alexander-Kern
Copy link
Member

Issue

This PR is to address Issue #443 .

Validation test (not part of this PR)

A second PR adding a validation test against the original MATLAB implementation by E. Russo is open here: #533 .

Changes

  • improve code-style (PEP8)
  • have the initial value of alpha under a separate name alph, this was also done in the original MTALB implementation.

@Moritz-Alexander-Kern Moritz-Alexander-Kern added the bugfix Fix for an indentified bug. label Jul 12, 2023
@Moritz-Alexander-Kern Moritz-Alexander-Kern changed the title Fix/cell assembly detection [Fix] cell assembly detection Jul 12, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jul 12, 2023

Coverage Status

coverage: 86.976% (+0.006%) from 86.97% when pulling 0830333 on INM-6:fix/cell_assembly_detection into 844eb82 on NeuralEnsemble:master.

@Moritz-Alexander-Kern Moritz-Alexander-Kern added this to the v0.13.0 milestone Jul 12, 2023
Copy link
Member Author

@Moritz-Alexander-Kern Moritz-Alexander-Kern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build wheels

@Moritz-Alexander-Kern Moritz-Alexander-Kern merged commit def50dc into NeuralEnsemble:master Jul 12, 2023
12 of 15 checks passed
@Moritz-Alexander-Kern Moritz-Alexander-Kern deleted the fix/cell_assembly_detection branch July 21, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix for an indentified bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants