Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

446 tests fail with neo-0.10.0 #1037

Closed
TheChymera opened this issue Oct 11, 2021 · 6 comments · Fixed by #1420
Closed

446 tests fail with neo-0.10.0 #1037

TheChymera opened this issue Oct 11, 2021 · 6 comments · Fixed by #1420
Assignees
Milestone

Comments

@TheChymera
Copy link
Contributor

This is the full build and test log: https://ppb.chymera.eu/f0c5ba.log
I assume some failures at least are due to network access (is there any way to easily skip tests which require network access), and some due to missing dependencies.

One thing I spotted is ipython — this is an interactive shell. Is any functionality of python-neo really dependent on an interactive Python shell?

@samuelgarcia
Copy link
Contributor

Hi @TheChymera.
Thank also for this packaging.

f you have any environment variable in mind to check if the test suite is running on your gentoo build box, tell us.
We can easily add then to skip theses test.

@TheChymera
Copy link
Contributor Author

Hi @samuelgarcia thank you for looking into this! The way many packages do this is that they either:

  1. have an environment variable such as PACKAGENAME_TESTS_NONETWORK (datalad for instance uses DATALAD_TESTS_NONETWORK)
  2. mark the tests with e.g. @pytest.mark.network so that they can be deselected when running pytest via pytest -m "not network".

@samuelgarcia
Copy link
Contributor

OK
I put that on my todo list.
I won't do it immediatly because I am a bit busy next 3 weeks but will do it soon.

@JuliaSprenger
Copy link
Member

@samuelgarcia Any news on this?

@JuliaSprenger JuliaSprenger added this to the 0.11.0 milestone Mar 3, 2022
@apdavison apdavison modified the milestones: 0.10.3, 0.11.0 Aug 30, 2022
@apdavison apdavison modified the milestones: 0.11.0, 0.12.0 Sep 29, 2022
@TheChymera
Copy link
Contributor Author

Still failing very many tests (506) on 0.11.1: https://ppb.chymera.eu/65897d.log

@TheChymera
Copy link
Contributor Author

Just to update, though it's probably “as expected” given the milestone, network tests still fail in a network sandbox and I can't see how to auto-disable them on
0.12.0 https://ppb.chymera.eu/6fae8d.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants