Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github action failure to release #799

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Fix github action failure to release #799

merged 2 commits into from
Apr 11, 2024

Conversation

wu-haoze
Copy link
Collaborator

No description provided.

@wu-haoze wu-haoze requested a review from wenkokke April 11, 2024 18:16
@wenkokke
Copy link
Collaborator

The wheelhouse-*-* patterns are there to match the uploads, so you need to make sure you upload the wheels with a unique name for each job, then match those names here.

@wenkokke
Copy link
Collaborator

This should be v4, because upload and download v3 and v4 are not mutually compatible:

# cibuuldwheel.yml
- uses: actions/upload-artifact@v3
        with:
          name: wheelhouse
          path: ./wheelhouse/*.whl

The name field should be some identifier that is unique for each run of that job. Probably wheelhouse-${{ runner.os }} suffices.

The pattern in the download should then match that, so wheelhouse-* in that case.

Copy link
Collaborator

@wenkokke wenkokke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

Copy link
Collaborator

@wenkokke wenkokke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright, probably worth another shot.

@wenkokke
Copy link
Collaborator

You'll have to recreate the tag.

@wenkokke wenkokke merged commit 215828c into master Apr 11, 2024
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants