Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Recursive Context instead of list context for different service cache levels #516

Closed
guillaume-chevalier opened this issue Oct 21, 2021 · 2 comments
Labels
enhancement New feature or request wontfix This will not be worked on
Milestone

Comments

@guillaume-chevalier
Copy link
Member

Is your feature request related to a problem? Please describe.
As the context acts like a stack of function calls with each level having its own "variables"-like saving in the context (e.g.: Memory (as per #443 ), it might be good that if adding a service at the middle of the pipeline, that the service is scoped and local to just this context.pushed level (like a programming language stack / Assembly CPU Stack that is cleared upon stack push).

Describe the solution you'd like
When pushing and popping to context, use a recursive context data structure instead of lists of parents and a single service dict. This was done originally in the first releases of Neuraxle ever, but that was change for some reasons I don't know. It seems that the original intuition was possibly better.

Describe alternatives you've considered
Singly-linked list (stack data structure / design pattern) for the context's parents, and services. Could set global v.s. local services as well (like programming languages' global v.s. local scopes when declaring/using variables).

Additional context
None

@guillaume-chevalier
Copy link
Member Author

Related: #485 so as to dig into contexts with apply and stuff like that to get the services.

@stale
Copy link

stale bot commented Apr 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in the next 180 days. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 24, 2023
@stale stale bot closed this as completed Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant