Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a better common base class for meta steps (that handles get_hyperparams and set_hyperparams) #28

Closed
guillaume-chevalier opened this issue Aug 8, 2019 · 2 comments · Fixed by #62
Assignees
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested

Comments

@guillaume-chevalier
Copy link
Member

Problem:

  • MetaStep and MetaSteps doesn't implement get_hyperparams nor set_hyperparams.
  • TruncableSteps does.

What should be done about it:

  • Move some logic from TruncableSteps to MetaSteps
  • Have MetaStep act the same, probably by inheriting MetaSteps but setting only one such meta step.

Other better solutions could probably be possible. Basically, we need not only to have nested (recursive) pipelines to be able to return their hyperparams, but also nested objects that are MetaStep(s). MetaStep(s) do contain other step(s) and should be able to get and set their hyperparams recursively as done in TruncableSteps.

@alexbrillant I'd like your thoughts on this.

@guillaume-chevalier
Copy link
Member Author

Same goes for spaces with set_hyperparams_space.

@guillaume-chevalier guillaume-chevalier added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested labels Aug 8, 2019
@alexbrillant alexbrillant mentioned this issue Sep 18, 2019
@alexbrillant
Copy link
Contributor

can we discuss this ? @guillaume-chevalier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants