Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Test files missing from sdist on PyPI #530

Open
jakirkham opened this issue Aug 17, 2022 · 1 comment
Open

Bug: Test files missing from sdist on PyPI #530

jakirkham opened this issue Aug 17, 2022 · 1 comment
Labels
bug Something isn't working invalid This doesn't seem right wontfix This will not be worked on

Comments

@jakirkham
Copy link

Describe the bug

Currently the testing_neuraxle directory is missing from the sdist on PyPI.

To Reproduce

curl -LO https://pypi.io/packages/source/n/neuraxle/neuraxle-0.8.1.tar.gz
tar xzf neuraxle-0.8.1.tar.gz
ls -1 neuraxle-0.8.1/testing_neuraxle

Expected behavior

Ideally the tests would be included in the sdist to make it easier to test after building/installing the package.

Suggested Fix

One solution would be to include a MANIFEST.in and add...

recursive-include testing_neuraxle *.py

...as well as anything else that might be needed to run the tests (like other directories or other extension types).

Additional context

This came up in trying to build & test a Conda package for conda-forge.

xref: conda-forge/staged-recipes#16566 (comment)


cc @guillaume-chevalier (for awareness)

@jakirkham jakirkham added bug Something isn't working invalid This doesn't seem right labels Aug 17, 2022
Copy link

stale bot commented Feb 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs in the next 180 days. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant