chebyshev_uniform for Generator1D #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,21 +4,25 @@ | |||
| import numpy as np | |||
| from typing import List | |||
|
|
|||
| def _chebyshev_uniform(a, b, n): | |||
There was a problem hiding this comment.
I am not sure that this makes sense. Chebyshev nodes are deterministic sequence of numbers. Its not a function which is valid for a random number.
I think Its better to define "chebyshev_noisy" which adds noise to the chebyshev sequence rather than doing this.
There was a problem hiding this comment.
Thank you for your comments, Sathvik! I pushed a new commit with an attempt of chebyshev_noisy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of my excellent learning experience in the Harvard ComputeFest 2024: Physics-Informed Neural Networks, I wanted to contribute to neurodiffeq. The perfect opportunity presented by initiative of @shuheng-liu. I open this pull request to create the
chebyshev_uniformmethod forGenerator1D. This should:I have also updated the documentation and added a test, accordingly.
Thank you!