Prevent some post-probabilistic rule to be considered as probabilistic #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgy
commented
Jan 18, 2021
| @@ -175,7 +175,7 @@ def _get_rule_idb_type(rule, grpd_symbs, wlq_symbs): | |||
| | grpd_symbs["post_probabilistic"] | |||
| ).issuperset(dep_symbs): | |||
| idb_type = "post_probabilistic" | |||
| elif not grpd_symbs["probabilistic"].isdisjoint(dep_symbs): | |||
| elif not (grpd_symbs["probabilistic"] - wlq_symbs).isdisjoint(dep_symbs): | |||
There was a problem hiding this comment.
this is a simple fix that excludes relations defined by within-language queries from the dependency check.
a rule is probabilistic here if it depends on another probabilistic rule that is NOT a WLQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an error where a rule depending on a post-probabilistic rule was considered
to be probabilistic, which cannot happen as any rule depending on a
post-probabilistic rule must be deterministic and in the post-probabilistic
stratum.