Increased flexibility of NML2ChannelAnalysis #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n constraint to be removed
This was referenced Jun 12, 2015
Closed
pgleeson
added a commit
that referenced
this pull request
Jun 15, 2015
Increased flexibility of NML2ChannelAnalysis
|
Thanks @rgerkin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows NML2ChannelAnalysis to be run more easily from within scripts, using keyword arguments.
It also makes more extensive use of the -v (verbose) argument by applying it more globally.
It also writes IVCurve files even in -nogui mode (since this should be independent of whether the IVCurve is displayed or not).
It computes steady-state currents based on the end of the clampDuration, rather than the end of the entire simulation, removing the need for the duration to be artificially short.
Lastly, it makes some edits to conform to style guidelines.
This pull request is necessary for this notebook to run correctly.