-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix broken CI #167
ci: fix broken CI #167
Conversation
@JohnGriffiths please be more careful next time, heh: 3efcb15
And @JohnGriffiths why is |
Ah, I assume psychtoolbox was to fix https://discourse.psychopy.org/t/missing-sound-libraries-for-psychopy3-standalone-release-3-2-3-for-win32/9162 However, it was already installed, so it had no effect. Added pygame instead. Edit: adding pygame also had no effect. |
I'd also like to note that the dependency hell that caused this would have been handled by poetry, were we to use it. |
Alright, so this PR got a bit messier than first thought. Looks like a bunch of issues arising from having a >2yr old version of psychopy... Hoping psychopy has decent backwards compatibility. |
Ugh, apparently psychopy now depends on tobii-research, which is only available for Python 3.8+ Python 3.7 is EOL in ~1 year anyway, might be time to bump it. |
Now only macOS is failing, needs something like bambocher/pocketsphinx-python#71 |
Fixed seaborn>=0.11 compatibility (which dropped tsplot). Building docs is still failing, but I don't think that's related to the changes. |
@JohnGriffiths This PR should now be an overall major improvement, but still some minor stuff needed (fix building docs & building on macOS). That'll have to wait for another PR though. There may still be bugs or more testing needed, esp with the updated versions of stuff, but it's not sustainable to stay on the old versions anyway (as that'll lead to its own problems) so better get this out of the way. |
Merging. |
Thanks for doing the work on this @ErikBjare . Timing is not great though as we have just launched NTCS this week with e-mail out to thousands of of openbci users and this merge has broken installation. |
Our Installation instructions currently say to use py37 and install wxpython.
I am troubleshooting this now but definitely just switching to Trying to recall now why we settled on that |
Also important = any installation instruction updates need to be reflected in the docs instructions, and currently we have a build failure in the docs, so can't actually change the documentation instructions. I have tried several times to resolve this problem but haven't been able to yet. The doc build seems to work fine on all local machines I've tried so a bit stumped. |
install with py38 is failing on two out of two windows machines for me now. have you tested this? are there extra install instructions? might need to revert this PR. @oreHGA @JadinTredup if you got a mo to check on this would be great as is pretty time critical. |
I'll jump on it Sorry about the NTCS launch, did not see the announcement until later! We can always create a revert commit and merge it back later. |
There are wxPython wheels for Python 3.8 here, as detailed in |
@JohnGriffiths I have a revert for this ready to go, just give me the word! |
Yeah I think revert for now and we can work on the PR as a priority matter
…On Sun., Mar. 27, 2022, 1:53 p.m. Erik Bjäreholt, ***@***.***> wrote:
@JohnGriffiths <https://github.com/JohnGriffiths> I have a revert for
this ready to go, just give me the word!
—
Reply to this email directly, view it on GitHub
<#167 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADBEAWNUY6FRKNL6J3EENDVCCVA5ANCNFSM5RTYZBGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This reverts commit 2d74871.
* Revert "Revert PR #167: "ci: fix broken CI" (#169)" This reverts commit 2d74871. * Update Makefile * fix: Update vep.py import * Update Makefile * Update vep.py * fix: typo in makefile * fix: update BaseExperiment class reference * Update Makefile * Update vep.py * Update 01r__n170_viz.py * makefile: install libnotify4 --------- Co-authored-by: Ore O <oreogundipe@gmail.com>
@JohnGriffiths please be more careful next time, heh: 3efcb15
TODO
Changes
tsplot
with custom function