-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support Python 3.8 (and 3.9 on Linux) #32
Conversation
841a67e
to
89055da
Compare
89055da
to
5d3a472
Compare
Looks like Another reason to look into #22 I guess. |
Might just have been the fact that wheels for Python 3.6 weren't available, bumping CI Python version to check if that's the case. |
CI passed, ready to merge (after #31) 🎉 |
Just want to check: do we think the user-supplied wheels is the best option here, or is the pywinhook issue largely solved by moving to python 3.7? |
@JohnGriffiths From a second look at https://pypi.org/project/pyWinhook/#files it seems like there exists pywinhook wheels on PyPI for Python 3.7 and 3.8 (news to me), but indeed not for 3.9. Since there are wheels available for 3.9 (here: https://www.lfd.uci.edu/~gohlke/pythonlibs/), we might want to change this PR to only supply prebuilt wheels for Python 3.9 (and maybe for 3.6 since that's not on PyPI either, but we'll probably want to drop 3.6 support soon anyway). Edit: It should be added that I intend to resolve issues with newer Python versions, as I've laid out in #50 |
Supports Python 3.9 on Linux now, but one remaining issue with tables 3.6.1 on macOS and Windows where wheels are missing and requires HDF5 headers to be available (see #50) |
Looks like pyriemann broke with the latest scikit-learn, submitted a fix: pyRiemann/pyRiemann#93 |
I'm OK with merging this. But shlukd we be e currently waiting for the pyriemann fix PRs to be accepted before doing so? |
If so, we'll need to lower the sklearn constraint again, and leave Python 3.9 support for another PR. I'd suggest we just wait for it to get merged (or if it takes too long, fork pyriemann ourselves and switch to using that). |
Depends on #31
Fixes #29, Fixes #50
Based on a similar solution in: ActivityWatch/aw-watcher-afk#44