Remove update_path from data_dl #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 15, 2021 23:55
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
Signed-off-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>
|
Removed reference to Use pooch retrieve instead of MNE on Weibo to solve an error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #195 we removed the
update_pathfrommoabb.datasets.download.data_dl(), and deprecated it formoabb.datasets.download.data_path. Not all datasets were updated accordingly. This patch correct this error.I'll make a revision bump from 0.4.0 to 0.4.1 to correct this, as this is a major issue is MOABB does not work to download some datasets.
Closes #206