dataset download fix #433
Merged
dataset download fix #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck off in http downloaders (not suggested)
|
Amazing @Sara04! Thank you much for this fixing. I didn't notice when I changed. I was wondering, can you add the fixing in the whats_news file. For me, this PR is good to be merged :) Thank you again! |
|
Thank you @bruAristimunha ! 😃 What's new is updated now. |
bruAristimunha
added a commit
to bruAristimunha/moabb
that referenced
this pull request
Aug 19, 2023
* Add possibility to have non-http downloaders; keeping certificate check off in http downloaders (not suggested) * [pre-commit.ci] auto fixes from pre-commit.com hooks * Update whats_new.rst --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Bru <a.bruno@aluno.ufabc.edu.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, fixes the problem of data download from servers with ftp (non-http) protocols. It keeps TLS certificate verification off in http downloaders (not suggested).