FIX empty dataset_list in python3.10 #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruAristimunha
approved these changes
Aug 3, 2023
|
Amazing @tomMoral! Can you please add your name and small description in the whats_news file? |
- FIX comment position due to pre-commit messing with the files
|
Thank you @tomMoral! |
bruAristimunha
pushed a commit
to bruAristimunha/moabb
that referenced
this pull request
Aug 19, 2023
* FIX empty dataset_list in python3.10 * [pre-commit.ci] auto fixes from pre-commit.com hooks * DOC add what's new entry - FIX comment position due to pre-commit messing with the files --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On python3.10, I got an empty list of datasets from
moabb.datasets.utils.This is due to the fact that
utilswas imported before__init__was fully set up.This PR intends to make this determinist, by calling
_init_dataset_listat the end of themoabb.datasets.__init__.py, with a test that checks that the list is complete.