Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX empty dataset_list in python3.10 #449

Merged
merged 3 commits into from Aug 4, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions moabb/datasets/__init__.py
Expand Up @@ -46,5 +46,12 @@
from .ssvep_nakanishi import Nakanishi2015
from .ssvep_wang import Wang2016
from .upper_limb import Ofner2017

# Call this last in order to make sure the dataset list contains all
# the datasets imported in this file.
from .utils import _init_dataset_list
from .Weibo2014 import Weibo2014
from .Zhou2016 import Zhou2016


_init_dataset_list()
3 changes: 0 additions & 3 deletions moabb/datasets/utils.py
Expand Up @@ -15,9 +15,6 @@ def _init_dataset_list():
dataset_list.append(ds[1])


_init_dataset_list()


def dataset_search( # noqa: C901
paradigm=None,
multi_session=False,
Expand Down
15 changes: 14 additions & 1 deletion moabb/tests/datasets.py
@@ -1,13 +1,16 @@
import inspect
import shutil
import tempfile
import unittest

import mne

from moabb import datasets as db
from moabb.datasets import Shin2017A, Shin2017B, VirtualReality
from moabb.datasets.base import BaseDataset
from moabb.datasets.compound_dataset import CompoundDataset
from moabb.datasets.fake import FakeDataset, FakeVirtualRealityDataset
from moabb.datasets.utils import block_rep
from moabb.datasets.utils import block_rep, dataset_list
from moabb.paradigms import P300


Expand Down Expand Up @@ -147,6 +150,16 @@ def test_dataset_accept(self):
if mne.get_config("MNE_DATASETS_BBCIFNIRS_PATH") is None:
self.assertRaises(AttributeError, ds.get_data, [1])

def test_dataset_list(self):
all_datasets = len(
[
issubclass(c, BaseDataset)
for c in db.__dict__.values()
if inspect.isclass(c)
]
)
assert len(dataset_list) == all_datasets


class Test_VirtualReality_Dataset(unittest.TestCase):
def __init__(self, *args, **kwargs):
Expand Down