Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize default path for erp visualization #279

Merged
merged 6 commits into from Apr 6, 2022
Merged

Generalize default path for erp visualization #279

merged 6 commits into from Apr 6, 2022

Conversation

jsosulski
Copy link
Collaborator

@jsosulski jsosulski commented Mar 4, 2022 •
edited

The ERP visualization script had an explicit home directory in the path. I generalized it to Path.home()

sylvchev
sylvchev requested changes Mar 17, 2022
View reviewed changes
Copy link
Member

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add
import os.path as osp
at the begining of the file

scripts/data_visualization_p300.py Outdated Show resolved Hide resolved
@sylvchev sylvchev merged commit 5b384b2 into develop Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvchev sylvchev sylvchev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsosulski @sylvchev