Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preload Schirrmsister2017 - Fixes #289 #290

Merged
merged 4 commits into from May 18, 2022

Conversation

PierreGtch
Copy link
Collaborator

Closes #289

Copy link
Member

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for this PR! Once you update the code, we could merge this.

moabb/datasets/schirrmeister2017.py Outdated Show resolved Hide resolved
@sylvchev
Copy link
Member

I'm updating some configuration files that causes a CI failure. It is not related with your code, but you will need to update your code branch with the latest develop branch. Feel free to ask if you are not sure how to do it.

@sylvchev sylvchev added bug dataset Supporting new dataset labels May 16, 2022
@PierreGtch
Copy link
Collaborator Author

I've implemented the comment and updated my branch :)

@sylvchev
Copy link
Member

Good, could you update the docs/source/whats_new.rst page to indicate this bug correction as well?

@PierreGtch
Copy link
Collaborator Author

Done, sorry forgot about that

@sylvchev
Copy link
Member

Thank you @PierreGtch !

@sylvchev sylvchev merged commit 87b3118 into NeuroTechX:develop May 18, 2022
@PierreGtch PierreGtch deleted the preload_schirrmeister branch June 23, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dataset Supporting new dataset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Schirrmeister2017 RawEDF not preloaded
2 participants