Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid Search on Evaluation #319

Merged
merged 32 commits into from Jan 25, 2023
Merged

Conversation

carraraig
Copy link
Collaborator

Grid Search implementation for the different evaluation function.

moabb/evaluations/base.py Outdated Show resolved Hide resolved
moabb/evaluations/base.py Outdated Show resolved Hide resolved
Copy link
Member

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carraraig
I spotted some weird loop in your code. Could you explained the reason for this loops or change your code to avoid repeating a grid search?

moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
@sylvchev
Copy link
Member

I merge the return_raw PR and there are some conflict now, but they should be easy to solved.

@carraraig
Copy link
Collaborator Author

Thanks @carraraig I spotted some weird loop in your code. Could you explained the reason for this loops or change your code to avoid repeating a grid search?

I agree with the problem, and solved as proposed

Copy link
Collaborator Author

@carraraig carraraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modification submitted

moabb/evaluations/base.py Outdated Show resolved Hide resolved
moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
Copy link
Member

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a nice PR, you could add grid search for benchmark when the tests are fixed

@sylvchev
Copy link
Member

Thanks @carraraig !

@sylvchev sylvchev merged commit 87544d3 into NeuroTechX:develop Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants