Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beanchmark grid search #323

Merged
merged 35 commits into from Jan 26, 2023
Merged

Beanchmark grid search #323

merged 35 commits into from Jan 26, 2023

Conversation

carraraig
Copy link
Collaborator

Grid search implementation in Benchmark function

carraraig and others added 26 commits January 10, 2023 18:25
@carraraig
Grid Search on Evaluation
edeee9c
@carraraig
whats_new changed
9c41acf
@carraraig
GridSearchCV handle with None value
e38c992
@carraraig
Updated Test
fad9c42
@carraraig
Unchanged Learning Curve
2a6b6b9
@carraraig
Example GridSearch WithinSession
626a504
@bruAristimunha @sylvchev
Update moabb/evaluations/base.py
ea60a5e 
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
@bruAristimunha
Trying
954c51b
@bruAristimunha
Rename and changing the path
f0c0b65
@bruAristimunha
Updating the README.txt
9c647a2
@bruAristimunha
Adding the header
80ef758
@bruAristimunha
Applying str in the var self.hdf5_path
144c8fa
@carraraig
Example GridSearch WithinSession with plot and parameter displayed
ef8a16b
@carraraig
Evaluation with modification
d10e749
@carraraig
Merge branch 'develop' into grid_search
8aa1ce8
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4c4cc2c
@carraraig
Evaluation with modification
abec2c1
@carraraig
Merge remote-tracking branch 'origin/grid_search' into grid_search
d43ad74
@carraraig
Example Fix
85fd691
@carraraig
Example Fix
ec0686d
update example
a9e9b04
@carraraig
Evaluation fix sefl.hdf5 path
0b3e64f
@carraraig
Merge remote-tracking branch 'origin/grid_search' into grid_search
5db79cb
@carraraig
Evaluation with function for GridSearch
820a6a0
@carraraig
Benchmark with gridsearch + Example
7a30bda
@bruAristimunha
Merge branch 'develop' into beanchmark_grid_search
aa657df
@sylvchev
Copy link
Member

sylvchev commented Jan 25, 2023 •
edited

I merged the PR for the grid search in evaluation. Could you rebase this branch to avoid double commit?
EDIT: I solve the conflict and we will squash commits when merging this PR, so it is good.

@sylvchev
Copy link
Member

@carraraig Could you check the errors in test_benchmark?

@carraraig
Copy link
Collaborator Author

@carraraig Could you check the errors in test_benchmark?

To solve this we need to have in each pipeline.yml the key

param_grid: None

If we don't want to use the grid search.

sylvchev
sylvchev reviewed Jan 26, 2023
View reviewed changes
moabb/pipelines/utils.py Outdated Show resolved Hide resolved
examples/pipelines_grid/EN.yml Outdated Show resolved Hide resolved
examples/pipelines_grid/EN_grid.yml Show resolved Hide resolved
examples/plot_benchmark_grid_search.py Outdated Show resolved Hide resolved
examples/plot_benchmark_grid_search.py Outdated Show resolved Hide resolved
examples/plot_benchmark_grid_search.py Outdated Show resolved Hide resolved
moabb/tests/test_pipelines/CSP.yml Outdated Show resolved Hide resolved
sylvchev
sylvchev approved these changes Jan 26, 2023
View reviewed changes
moabb/pipelines/utils.py Outdated Show resolved Hide resolved
moabb/pipelines/utils.py Outdated Show resolved Hide resolved
moabb/pipelines/utils.py Outdated Show resolved Hide resolved
@sylvchev sylvchev merged commit 8819f8b into NeuroTechX:develop Jan 26, 2023
@sylvchev
Copy link
Member

thanks @carraraig ! This is really a nice addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvchev sylvchev sylvchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carraraig @sylvchev @bruAristimunha