Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax upper bound on ipywidgets #260

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Relax upper bound on ipywidgets #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55dfca8
Update requirements.txt
CodyCBakerPhD Jan 31, 2023
9f85113
Update base.py
CodyCBakerPhD Jan 31, 2023
b2a8c3f
Update CHANGELOG.md
CodyCBakerPhD Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@
# v0.10.1

* Added a trialized widget for TimeSeries. [PR #232](https://github.com/NeurodataWithoutBorders/nwbwidgets/pull/232)
* Loosened upper bound version on `ipywidgets`. [PR #260](https://github.com/NeurodataWithoutBorders/nwbwidgets/pull/260)
2 changes: 1 addition & 1 deletion nwbwidgets/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def lazy_show_over_data(list_, func_, labels=None, style: GroupingWidget = widge
children = [vis2widget(func_(list_[0]))] + [widgets.HTML("Rendering...") for _ in range(len(list_) - 1)]
out = style(children=children)
if labels is not None:
[out.set_title(i, label) for i, label in enumerate(labels)]
[out.set_title(i, str(label)) for i, label in enumerate(labels)]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bendichter This fixed it

I guess one of the labels in the test cases was actually an integer, and at some point they stopped magically casting it as a string during set_title

We should probably do it elsewhere we set titles as well just to be sure, but that can be separate PR


def on_selected_index(change):
if change.new is not None and isinstance(change.owner.children[change.new], widgets.HTML):
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ pynwb
ipympl
ipydatagrid
ipyvolume>=0.6.0a10
ipywidgets>=7.4.0, <8.0.0
ipywidgets>=8.0.0
plotly
tqdm>=4.36.0
zarr
Expand Down