Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if x is in electrodes #280

Merged
merged 3 commits into from Feb 24, 2023
Merged

check if x is in electrodes #280

merged 3 commits into from Feb 24, 2023

Conversation

bendichter
Copy link
Collaborator

fix #278

check if x is in electrodes
add test

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #280 (0725666) into master (4705b2f) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   66.16%   66.27%   +0.11%     
==========================================
  Files          35       35              
  Lines        3443     3443              
==========================================
+ Hits         2278     2282       +4     
+ Misses       1165     1161       -4     
Flag Coverage Δ
unittests 66.27% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwbwidgets/ecephys.py 63.36% <100.00%> (+3.96%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CodyCBakerPhD CodyCBakerPhD merged commit fe21c43 into master Feb 24, 2023
@CodyCBakerPhD CodyCBakerPhD deleted the fix_electrodes branch February 24, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: render electrodes metadata table when column (e.g. 'x') is missing
2 participants