Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rmv trials from outer accordian #281

Merged
merged 3 commits into from Feb 24, 2023
Merged

rmv trials from outer accordian #281

merged 3 commits into from Feb 24, 2023

Conversation

bendichter
Copy link
Collaborator

@bendichter bendichter commented Feb 24, 2023

make trials not present on the outer level of the accordion. It must be accessed through Intervals

fix #272
fix #263

trials_demo.mov
panel_demo.mov

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #281 (4705b2f) into master (b228e6a) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
- Coverage   66.17%   66.16%   -0.01%     
==========================================
  Files          35       35              
  Lines        3441     3443       +2     
==========================================
+ Hits         2277     2278       +1     
- Misses       1164     1165       +1     
Flag Coverage Δ
unittests 66.16% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nwbwidgets/panel.py 77.48% <ø> (ø)
nwbwidgets/file.py 70.21% <50.00%> (-0.90%) ⬇️
nwbwidgets/utils/dandi.py 95.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

bendichter and others added 2 commits February 24, 2023 14:11
* fix docstring of Panel
* add necessary requirements
* add test for panel
* filter asset paths to only those that end with ".nwb"
@CodyCBakerPhD
Copy link
Collaborator

Wonderful, I confirmed that both fixes work!

Thanks a lot @bendichter!

@CodyCBakerPhD CodyCBakerPhD merged commit 62e4ad2 into master Feb 24, 2023
@CodyCBakerPhD CodyCBakerPhD deleted the fix_trials branch February 24, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants