New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix of gauss_2d_large(seed=63)
-> NaN
#76
Conversation
`kcsd.validation.csd_profile.gauss_2d_large(seed=63)` does not return NaN anymore. `repeatUntilValid()` decorator has been defined for that purpose. A simple test for the fix provided in the `__main__` section of the module. Note: The issue has not been solved by fixing distribution of the `zs` variable in order to provide backward-compatibility.
Pull Request Test Coverage Report for Build 159
💛 - Coveralls |
…on.csd_profile.repeatUntilValid()` decorator.
Nice workaround! Although I only tested for seeds between 1-100, maybe the seeds else where have the same issue? |
@ccluri Thanks! I have not checked the other functions but I will do in a moment. A respective commit shall arrive today. |
I would say use something like |
@ccluri The actual seed for BTW: I am testing the
So far (for 0 <= seed < 600000) only |
Okay, let me know when you are content with the update - I am happy to merge when you are. |
…ely) neverending loop of seeds.
Seed sequence generation moved to `seedSequence()` generator function.
…e has changed though).
@ccluri I have tested 46600000 seeds. No NaNs returned by other functions. |
kcsd.validation.csd_profile.gauss_2d_large(seed=63)
does not returnNaN anymore.
repeatUntilValid()
decorator has been defined for that purpose.A simple test for the fix provided in the
__main__
section of the module.Note: The issue has not been solved by fixing distribution of
the
zs
variable in order to provide backward-compatibility.