Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select uses 1000 microsecond timeout #6

Closed
mdeneen opened this issue Feb 26, 2014 · 2 comments
Closed

select uses 1000 microsecond timeout #6

mdeneen opened this issue Feb 26, 2014 · 2 comments

Comments

@mdeneen
Copy link

mdeneen commented Feb 26, 2014

Why is this so short?

https://github.com/NeuronRobotics/nrjavaserial/blob/master/nrjavaserial/src/main/c/src/SerialImp.c#L4149

I believe that this effectively turns the select into polling with such a short timeout. Can this number be increased, or am I not understanding how the event loop works?

@MrDOS
Copy link
Contributor

MrDOS commented Nov 23, 2015

No, your understanding of how the event loop works is correct. #22 hypothesized that RXTX originally used a 100ms timeout on the select(2) call, but I've been unable to locate whatever commit changed that. Either way, this has been increased again as of ea5c096 and #48.

Thanks for bringing this up.

@MrDOS MrDOS closed this as completed Nov 23, 2015
@MrDOS MrDOS added this to the 3.12.0 milestone Nov 23, 2015
@mdeneen
Copy link
Author

mdeneen commented Nov 24, 2015

Awesome! I completely forgot that I opened this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants