Add secondary tap capabilities to TableRowInkWell (flutter#123036)

Added new parameters onSecondaryTap and onSecondaryTapDown
NevercodeHQ · Apr 17, 2023 · d801b74 · d801b74
1 parent 85d160c
commit d801b74
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 1 deletion.
diff --git a/packages/flutter/lib/src/material/data_table.dart b/packages/flutter/lib/src/material/data_table.dart
@@ -1189,6 +1189,8 @@ class TableRowInkWell extends InkResponse {
     super.onDoubleTap,
     super.onLongPress,
     super.onHighlightChanged,
+    super.onSecondaryTap,
+    super.onSecondaryTapDown,
     super.overlayColor,
     super.mouseCursor,
   }) : super(

diff --git a/packages/flutter/test/material/data_table_test.dart b/packages/flutter/test/material/data_table_test.dart
@@ -2070,6 +2070,51 @@ void main() {
       e.toString().contains('dataRowHeight == null || (dataRowMinHeight == null && dataRowMaxHeight == null)'))));
   });
 
+  group('TableRowInkWell', () {
+    testWidgets('can handle secondary taps', (WidgetTester tester) async {
+      bool secondaryTapped = false;
+      bool secondaryTappedDown = false;
+
+      await tester.pumpWidget(MaterialApp(
+        home: Material(
+          child: Table(
+            children: <TableRow>[
+              TableRow(
+                children: <Widget>[
+                  TableRowInkWell(
+                    onSecondaryTap: () {
+                      secondaryTapped = true;
+                    },
+                    onSecondaryTapDown: (TapDownDetails details) {
+                      secondaryTappedDown = true;
+                    },
+                    child: const SizedBox(
+                      width: 100.0,
+                      height: 100.0,
+                    ),
+                  ),
+                ],
+              ),
+            ],
+          ),
+        ),
+      ));
+
+      expect(secondaryTapped, isFalse);
+      expect(secondaryTappedDown, isFalse);
+
+      expect(find.byType(TableRowInkWell), findsOneWidget);
+      await tester.tap(
+        find.byType(TableRowInkWell),
+        buttons: kSecondaryMouseButton,
+      );
+      await tester.pumpAndSettle();
+
+      expect(secondaryTapped, isTrue);
+      expect(secondaryTappedDown, isTrue);
+    });
+  });
+
   testWidgets('Heading cell cursor resolves MaterialStateMouseCursor correctly', (WidgetTester tester) async {
     await tester.pumpWidget(
       MaterialApp(
@@ -2233,5 +2278,4 @@ void main() {
     // Test that cursor is updated for the row.
     expect(RendererBinding.instance.mouseTracker.debugDeviceActiveCursor(1), SystemMouseCursors.copy);
   });
-
 }