E Table组件自定义rowSelection的rowKey #490

menggeNiu · 2019-09-17T06:39:09Z

close #485

liufei · 2019-09-17T06:43:28Z

https://react-impression-490.surge.sh

lusssn · 2019-09-17T08:46:43Z

packages/react-impression/src/components/TableBody/TableBody.js

@@ -173,6 +174,7 @@ export default class TableBody extends React.PureComponent {
      fixLeftList = fixLeft ? fixLeftColumns : fixRightColumns
      fixRightList = fixLeft ? fixRightColumns : fixLeftColumns
    }
+    const rowKey = this.props.rowSelection?.rowKey ?? ''


这个写法没有看懂是什么意思

可选链和双问号

liufei · 2019-11-04T08:40:15Z

babel.config.js

@@ -44,5 +44,7 @@ module.exports = {
      },
    ],
    '@babel/plugin-transform-runtime',
+    '@babel/plugin-proposal-optional-chaining',
+    '@babel/plugin-proposal-nullish-coalescing-operator',


这两个提案还处于stage 3，建议等到stage 4再用

niumengge added 5 commits September 4, 2019 19:57

A

12a4456

A fix

d49c71f

A readme

a4e2e30

U 木偶组件下不存在rowKey时逻辑

47f6c1f

U readme

069740d

menggeNiu requested review from liufei, lusssn, natsu0728 and yaqunliu September 17, 2019 06:39

lusssn reviewed Sep 17, 2019

View reviewed changes

liufei suggested changes Nov 4, 2019

View reviewed changes

liufei modified the milestones: 2.0.10, 2.1 Nov 4, 2019

lusssn self-requested a review November 4, 2019 10:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

E Table组件自定义rowSelection的rowKey #490

E Table组件自定义rowSelection的rowKey #490

menggeNiu commented Sep 17, 2019

liufei commented Sep 17, 2019

lusssn Sep 17, 2019

menggeNiu Sep 17, 2019

liufei Nov 4, 2019

E Table组件自定义rowSelection的rowKey #490

Are you sure you want to change the base?

E Table组件自定义rowSelection的rowKey #490

Conversation

menggeNiu commented Sep 17, 2019

liufei commented Sep 17, 2019

lusssn Sep 17, 2019

Choose a reason for hiding this comment

menggeNiu Sep 17, 2019

Choose a reason for hiding this comment

liufei Nov 4, 2019

Choose a reason for hiding this comment