Adding tslint-react with neworbit rules #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jameskmonger
suggested changes
Sep 19, 2018
tslint.json
Outdated
|
|
||
| // start tslint-react rules | ||
| "jsx-alignment": true, | ||
| "jsx-ban-props": [true, ["style", "use className and css"]], |
There was a problem hiding this comment.
Indentation here is all out of wack - you also can't have comments in JSON
package.json
Outdated
| @@ -1,13 +1,14 @@ | |||
| { | |||
| "name": "neworbit-tslint-config", | |||
| "version": "2.0.3", | |||
| "version": "3.0.0", | |||
There was a problem hiding this comment.
Undo the version change here please (make sure you reupdate package-lock)
Jameskmonger
suggested changes
Sep 19, 2018
tslint.json
Outdated
| @@ -39,6 +39,19 @@ | |||
| "interface-name": false, | |||
| "interface-over-type-literal": false, | |||
| "jsdoc-format": true, | |||
| "jsx-alignment": true, | |||
| "jsx-ban-props": [true, ["style", "use className and css"]], | |||
There was a problem hiding this comment.
Indentation is still out of wack (check it on the GitHub diff page if it looks okay on your VS Code)
Jameskmonger
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.