This repository has been archived by the owner on Jan 10, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will bring:
Cache misses are going to be painful. Not only do we have the issue of waiting for the file to download and then the file to be scanned, we have the issue of multiple people making requests before the dynamic duration data can be cached. Currently, this actually sort of works, but it still requires a scan of the file each time.
I'm wondering if it wouldn't be a better case scenario to require duration for audio in EE going forward, and then run a script against the EE database to set the duration for old entries? This would drastically cut down on cache miss times, and the complexity needed to handle multiple cache misses.
If not, we will need some kind of queuing or event based system to handle multiple cache misses, so that the file is only downloaded and scanned one time.