Skip to content
This repository has been archived by the owner on Jan 10, 2020. It is now read-only.

[WIP] Sermon audio #103

Merged
merged 5 commits into from
Aug 3, 2016
Merged

[WIP] Sermon audio #103

merged 5 commits into from
Aug 3, 2016

Conversation

johnthepink
Copy link
Contributor

This will bring:

  1. sermon audio
  2. dynamic mp3 duration calculation

Cache misses are going to be painful. Not only do we have the issue of waiting for the file to download and then the file to be scanned, we have the issue of multiple people making requests before the dynamic duration data can be cached. Currently, this actually sort of works, but it still requires a scan of the file each time.

I'm wondering if it wouldn't be a better case scenario to require duration for audio in EE going forward, and then run a script against the EE database to set the duration for old entries? This would drastically cut down on cache miss times, and the complexity needed to handle multiple cache misses.

If not, we will need some kind of queuing or event based system to handle multiple cache misses, so that the file is only downloaded and scanned one time.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 31.983% when pulling 348befc47c28030bc9c206c5cafe99969350c7e7 on sermon-audio into 2668071 on master.

@johnthepink
Copy link
Contributor Author

Let's leave this unmerged. I'm pushing it to alpha for purposes of developing and testing the sermon audio UI on devices. But, I imagine we will pull out the dynamic duration calculation before merging

@johnthepink
Copy link
Contributor Author

Actually, merging so it doesn't get overwritten by more deploys.

@johnthepink johnthepink merged commit e5eae04 into master Aug 3, 2016
@jbaxleyiii jbaxleyiii deleted the sermon-audio branch August 3, 2016 13:34
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 34.433% when pulling c01aab0 on sermon-audio into 8bd20ef on master.

@johnthepink johnthepink mentioned this pull request Aug 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants