Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAS 3.1 Webhook support #65

Merged
merged 3 commits into from
Apr 20, 2020
Merged

OAS 3.1 Webhook support #65

merged 3 commits into from
Apr 20, 2020

Conversation

mheap
Copy link
Contributor

@mheap mheap commented Apr 17, 2020

Adds support for rendering OAS 3.1 style webhooks if they exist in the specification.

Depends on Nexmo/oas_parser#48 and will need updating to point to a tagged release once it's merged

@mheap
Copy link
Contributor Author

mheap commented Apr 17, 2020

@fabianrbz This works locally for me, and for you. Any thoughts on if it's Travis?

@fabianrbz
Copy link
Contributor

@mheap i'm quite certain it is a travis issue, also it's going through a scheduled maintenance today :/

@mheap
Copy link
Contributor Author

mheap commented Apr 20, 2020

@fabianrbz Others seem to be hitting it too. There's a potential fix at Nexmo/oas_parser#49

Any downsides to explicitly requiring Path?

@fabianrbz
Copy link
Contributor

@mheap none at all, in fact it should be required

@mheap
Copy link
Contributor Author

mheap commented Apr 20, 2020

@fabianrbz Build is passing! :shipit: ?

Copy link
Contributor

@fabianrbz fabianrbz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mheap mheap merged commit 612eef7 into master Apr 20, 2020
@mheap mheap deleted the oas-3.1-webhooks branch April 20, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants