Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_connected api for expansion \w @Willy-JL #2

Closed
wants to merge 2 commits into from

Conversation

HaxSam
Copy link
Member

@HaxSam HaxSam commented Mar 1, 2024

What's new

  • Added new API to expansion to get the information if an expansion is initialized
  • The expansion_worker communicates back to the control if there is an RPC connection
  • new state for expansion for an established connection

@Willy-JL was heavily involved


For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@HaxSam
Copy link
Member Author

HaxSam commented Mar 1, 2024

Still need to add a better comment in expension.h but is nicer to view the changes here to see if I overlooked something at code review.

@HaxSam HaxSam marked this pull request as draft March 1, 2024 13:10
@HaxSam HaxSam marked this pull request as ready for review March 1, 2024 14:45
@HaxSam HaxSam mentioned this pull request Mar 1, 2024
5 tasks
@HaxSam HaxSam closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant