Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aida 674 #156

Merged
merged 9 commits into from
Apr 4, 2019
Merged

Aida 674 #156

merged 9 commits into from
Apr 4, 2019

Conversation

sharknc
Copy link
Contributor

@sharknc sharknc commented Apr 3, 2019

…us by base class (Entity, Event, or Relation)

Implemented invalid and valid test cases for new restriction
…nds, it is a duplication of validEventRelationAndEventRelationEdge

Added TODO comments to revisit this test case one the new design of ExamplesAndTest.java has been solidified
@sharknc sharknc requested review from eaciv, nextcen-dgemoets and craigwarsaw and removed request for nextcen-dgemoets April 3, 2019 16:19
Copy link
Collaborator

@eaciv eaciv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a change to the SHACL to get a better violation report

sh:select """
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX aida: <https://tac.nist.gov/tracks/SM-KBP/2018/ontologies/InterchangeOntology#>
SELECT $this (COUNT(?cluster) AS ?value)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't tell from the return value which cluster or Entity/Event/Relation violates this. Rather than a count, this should probably indicate which Entity/Event/Relation doesn't match which cluster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

…tBeHomogeneous tests class

Updated shacl restriction to output cluster member and cluster that causes any invalid errors
@eaciv
Copy link
Collaborator

eaciv commented Apr 4, 2019

Your shacl works, but having the values in the message is a little different than what I've seen. If you want to put the violation into report parameters, take a look at this:
674Suggestion.patch.txt

I tried to add this to our conversation, but it wouldn't let me attach files there.

@sharknc
Copy link
Contributor Author

sharknc commented Apr 4, 2019

Your shacl works, but having the values in the message is a little different than what I've seen. If you want to put the violation into report parameters, take a look at this:
674Suggestion.patch.txt

I tried to add this to our conversation, but it wouldn't let me attach files there.

I see. I thought the goal was to get the error in the resultMessage, but after seeing it in the report seems like a much better solution. Also, I didn't realize there were other pre-bound variables like $value that we can attach to, very cool, thanks for the heads up on that. I have made your suggested updates so the report now shows the erroneous cluster and cluster member in the report.

@eaciv eaciv merged commit b148032 into master Apr 4, 2019
@gitnordt gitnordt deleted the AIDA-674 branch November 15, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants