-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aida 674 #156
Conversation
sharknc
commented
Apr 3, 2019
- Created hypothesis restriction to enforce all clusters must be homogeneous by base class (Entity, Event, or Relation)
- Created valid and invalid test cases to validate the new aforementioned hypothesis restriction
- Updated all other hypothesis test cases that were impacted by the required importance value
- Updated all Hypothesis examples to include more detailed notification strings to help disambiguate output for https://nextcentury.atlassian.net/wiki/spaces/AIDAC/pages/507347434/Example+AIF+that+pass+and+fail+NIST+validations
…us by base class (Entity, Event, or Relation) Implemented invalid and valid test cases for new restriction
…nds, it is a duplication of validEventRelationAndEventRelationEdge Added TODO comments to revisit this test case one the new design of ExamplesAndTest.java has been solidified
… strings on valid and invalid test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a change to the SHACL to get a better violation report
sh:select """ | ||
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> | ||
PREFIX aida: <https://tac.nist.gov/tracks/SM-KBP/2018/ontologies/InterchangeOntology#> | ||
SELECT $this (COUNT(?cluster) AS ?value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't tell from the return value which cluster or Entity/Event/Relation violates this. Rather than a count, this should probably indicate which Entity/Event/Relation doesn't match which cluster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
…tBeHomogeneous tests class Updated shacl restriction to output cluster member and cluster that causes any invalid errors
Your shacl works, but having the values in the message is a little different than what I've seen. If you want to put the violation into report parameters, take a look at this: I tried to add this to our conversation, but it wouldn't let me attach files there. |
I see. I thought the goal was to get the error in the resultMessage, but after seeing it in the report seems like a much better solution. Also, I didn't realize there were other pre-bound variables like |
… visible in the validation report