Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from slash to hash for consistency; change isi.edu to darpa.mil #28

Merged
merged 1 commit into from
Jul 12, 2018

Conversation

cedorman
Copy link
Collaborator

The seedling ontology was using "/" but the other ontologies were using '#'. Change to use them consistently. Also, change namespace from www.isi.edu to darpa.mil to be consistent with Ontology generation in verdi code from LDC data.

@cedorman cedorman requested a review from eaciv July 12, 2018 13:34
Copy link
Collaborator

@eaciv eaciv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a TODO to remove the annotations prefix from the ontology

@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
@prefix aidaDomainCommon: <http://darpa.mil/ontologies/AidaDomainOntologiesCommon#> .
@prefix ldc: <http://darpa.mil/annotations/ldc#> .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a big deal, but we probably don't need this for the ontology.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will add it to the list of things to do.

@cedorman cedorman merged commit a92a776 into master Jul 12, 2018
@gitnordt gitnordt deleted the UseHashConsistently branch November 15, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants