Aida 280 #45
Merged
Aida 280 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eaciv
requested changes
Jul 23, 2018
| sh:targetClass rdf:Statement ; | ||
| sh:nodeKind sh:IRI ; | ||
| sh:message "All rdf:Statement nodes must not be blank" ; | ||
| . |
There was a problem hiding this comment.
Clark wants all files to end with a newline character. Please add a blank line at the end of this file
| * Returns whether or not the KB and hypotheses are valid | ||
| */ | ||
| fun validateTA3(dataToBeValidated: Model): Boolean { | ||
| val unionModel = ModelFactory.createUnion(domainModel, dataToBeValidated) |
There was a problem hiding this comment.
It's unfortunate that this might be done twice. Is there a way to prevent that?
There was a problem hiding this comment.
I came up with a solution. Let me know if you prefer the old method, and I will revert.
eaciv
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created SHACL to enforce uri for assertions.