Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the condition to permit the deletion of all view zone #1757

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

Censseo
Copy link
Contributor

@Censseo Censseo commented Sep 27, 2020

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Gis70 Gis70 self-requested a review September 27, 2020 20:42
@Gis70
Copy link

Gis70 commented Sep 27, 2020

Tu peux décrire ce qu'il faut regarder dans la pr stp

@Censseo
Copy link
Contributor Author

Censseo commented Sep 27, 2020

Lorsqu'on supprime toutes les zones d'une vue, il n'y a pas de sauvegarde. J'ai corrigé pour que lorsqu'on supprime tous les blocs ce soit bien pris en compte.

@Gis70
Copy link

Gis70 commented Sep 28, 2020

Good job !

@Gis70 Gis70 added the BUG Issue indiquant quelque chose qui ne fonctionne pas comme attendu label Sep 28, 2020
@Censseo Censseo merged commit 3217417 into develop Sep 30, 2020
@Censseo Censseo deleted the bugfix/save_view_no_zone branch September 30, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Issue indiquant quelque chose qui ne fonctionne pas comme attendu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants